mirror of
https://github.com/boykopovar/AnyPS5.git
synced 2026-10-22 08:33:12 -05:00
xXPBSXxandClaude Sonnet 5.5
89b04548c8
pr_overlap.py let a failed git or gh call escape as a bare CalledProcessError traceback that names the command but drops the error text, so a mistyped --base such as upstream/main (refs/heads/upstream/main does not exist) read as an unexplained crash. The script now exits with "pr_overlap: <command> failed with exit code N: <stderr>". Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
42 lines
1.8 KiB
Python
42 lines
1.8 KiB
Python
import runpy
|
|
import subprocess
|
|
import sys
|
|
import unittest
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
sys.path.insert(0, str(Path(__file__).resolve().parents[1]))
|
|
import pr_overlap
|
|
|
|
SCRIPT = Path(pr_overlap.__file__)
|
|
MISSING_REF = "fatal: couldn't find remote ref refs/heads/upstream/main"
|
|
|
|
|
|
def fake_run(command, **kwargs):
|
|
if command[0] == "gh":
|
|
return subprocess.CompletedProcess(command, 0, stdout="[]", stderr="")
|
|
return subprocess.CompletedProcess(command, 128, stdout=b"", stderr=MISSING_REF.encode())
|
|
|
|
|
|
class ErrorReportTests(unittest.TestCase):
|
|
def test_failure_names_the_command_the_exit_code_and_the_git_message(self):
|
|
error = subprocess.CalledProcessError(128, ["git", "fetch", "-q"], output="", stderr=MISSING_REF + "\n")
|
|
message = pr_overlap.describe_failure(error)
|
|
self.assertEqual(message, "pr_overlap: git fetch -q failed with exit code 128: " + MISSING_REF)
|
|
|
|
def test_failure_without_output_says_so(self):
|
|
error = subprocess.CalledProcessError(1, ["gh", "api"], output="", stderr="")
|
|
self.assertEqual(pr_overlap.describe_failure(error), "pr_overlap: gh api failed with exit code 1: no error output")
|
|
|
|
def test_unknown_base_branch_exits_with_the_git_message_instead_of_a_traceback(self):
|
|
argv = ["pr_overlap.py", "--repo", "owner/project", "--base", "upstream/main", "--branch", "HEAD"]
|
|
with patch.object(subprocess, "run", side_effect=fake_run), patch.object(sys, "argv", argv):
|
|
with self.assertRaises(SystemExit) as raised:
|
|
runpy.run_path(str(SCRIPT), run_name="__main__")
|
|
self.assertIn("exit code 128", str(raised.exception.code))
|
|
self.assertIn(MISSING_REF, str(raised.exception.code))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|