Files
AnyPS5/core/libs/tests/GuestAllocatorFailures.cpp
T
milescovielloandClaude Opus 5.5 1c9d9d6bc5 fix(build): run the CPU-side tests in an ANYPS5_ENABLE_ASAN build
Under -DANYPS5_ENABLE_ASAN=ON with ASAN_OPTIONS=detect_leaks=0, 14 of
the 849 tests outside the AGC driver, shader and VideoOut suites failed
on main for reasons that come from the ASan build itself, not from the
code they test:

- libc copies the main executable's file-backed writable pages before
  remapping them anonymously. In an instrumented test executable those
  pages hold ASan's redzones around globals, so the memcpy reported a
  global-buffer-overflow at load (patched_libraries,
  guest_memory_lifetime). The ASan build copies the pages word by word
  without instrumentation.
- Five tests check that a local variable is on the thread's stack.
  With detect_stack_use_after_return, which is on by default on Linux,
  instrumented locals live on ASan's fake stack. These tests now run
  with it off. guest_kernel_is_stack also bounded the worker stack by
  the application area without the ASan build's arena offset.
- The relinker module tests and loadexec_arguments load instrumented
  libraries into a Python process or a relinked guest, so the ASan
  runtime is not first in the initial library list. They now run with
  verify_asan_link_order=0. Preloading libasan instead put its
  __cxa_throw interceptor ahead of libc.prx's and broke the unwind of
  an exception that LoadExec throws and catches.
- guest_allocator_failures limits RLIMIT_DATA to 128 MiB and then
  commits 300 GiB. ASan maps 37.5 GiB of shadow for that commit, which
  the limit refuses, and aborts. The ASan build skips that section.
- fiber checks the address of a local against the fiber's context too,
  so it runs without fake stacks as well. Its CheckActiveContext then
  reads the fiber stack word by word above that local, through the
  redzones of the frames on that stack, and is no longer instrumented.
- agc_multisample_guest_access passed aligned_alloc a size that is not
  a multiple of the alignment, which C11 does not allow and ASan
  rejects. It now rounds the size up.

add_asan_test_options appends to ASAN_OPTIONS for one test in an ASan
build and does nothing otherwise.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 13:55:21 +00:00

202 lines
8.9 KiB
C++

#include "prx/libc/include/ApplicationHeap.hpp"
#include "prx/libc/include/GuestArena.hpp"
#include "prx/libc/include/general/VabiMacros.hpp"
#include <algorithm>
#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <cstring>
#include <exception>
#include <limits>
#ifdef __linux__
#include <sys/resource.h>
#endif
extern "C" {
void* APS5_VABI malloc_nid_postfix(std::size_t);
void* APS5_VABI calloc_nid_postfix(std::size_t, std::size_t);
void* APS5_VABI realloc_nid_postfix(void*, std::size_t);
void* APS5_VABI memalign_nid_postfix(std::size_t, std::size_t);
void* APS5_VABI aligned_alloc_nid_postfix(std::size_t, std::size_t);
int APS5_VABI posix_memalign_nid_postfix(void**, std::size_t, std::size_t);
void APS5_VABI free_nid_postfix(void*);
int* APS5_VABI __error_nid_postfix();
}
namespace {
constexpr int NoMemory = 12;
constexpr int InvalidArgument = 22;
constexpr std::size_t Max = std::numeric_limits<std::size_t>::max();
constexpr std::size_t HalfPlusOne = static_cast<std::size_t>(std::numeric_limits<std::ptrdiff_t>::max()) + 1;
int failures = 0;
void report(const char* what, const char* detail) {
std::fprintf(stderr, "%s: %s\n", what, detail);
++failures;
}
template<typename TCall>
void expectNull(const char* what, int expectedError, TCall call) {
*__error_nid_postfix() = 0;
void* result = nullptr;
try {
result = call();
} catch (const std::exception& error) {
std::fprintf(stderr, "%s: threw %s instead of returning NULL\n", what, error.what());
++failures;
return;
} catch (...) {
report(what, "threw a non-standard exception instead of returning NULL");
return;
}
if (result != nullptr) {
report(what, "returned a block");
free_nid_postfix(result);
return;
}
if (*__error_nid_postfix() != expectedError) {
std::fprintf(stderr, "%s: errno %d, expected %d\n", what, *__error_nid_postfix(), expectedError);
++failures;
}
}
template<typename TCall>
void* expectBlock(const char* what, TCall call) {
*__error_nid_postfix() = 77;
void* result = nullptr;
try {
result = call();
} catch (const std::exception& error) {
std::fprintf(stderr, "%s: threw %s\n", what, error.what());
++failures;
return nullptr;
}
if (result == nullptr) report(what, "returned NULL");
if (*__error_nid_postfix() != 77) report(what, "changed errno on success");
return result;
}
}
int main() {
void* api[10]{};
ApplicationHeapRegister_nid_no_patch(api);
expectNull("malloc(SIZE_MAX)", NoMemory, [] { return malloc_nid_postfix(Max); });
expectNull("malloc(PTRDIFF_MAX + 1)", NoMemory, [] { return malloc_nid_postfix(HalfPlusOne); });
expectNull("calloc(SIZE_MAX, 2)", NoMemory, [] { return calloc_nid_postfix(Max, 2); });
expectNull("calloc(2^33, 2^33)", NoMemory, [] { return calloc_nid_postfix(std::size_t{1} << 33, std::size_t{1} << 33); });
expectNull("calloc(PTRDIFF_MAX + 1, 1)", NoMemory, [] { return calloc_nid_postfix(HalfPlusOne, 1); });
expectNull("realloc(NULL, SIZE_MAX)", NoMemory, [] { return realloc_nid_postfix(nullptr, Max); });
expectNull("aligned_alloc(64, SIZE_MAX)", NoMemory, [] { return aligned_alloc_nid_postfix(64, Max); });
expectNull("memalign(64, PTRDIFF_MAX + 1)", NoMemory, [] { return memalign_nid_postfix(64, HalfPlusOne); });
expectNull("aligned_alloc(24, 64)", InvalidArgument, [] { return aligned_alloc_nid_postfix(24, 64); });
expectNull("aligned_alloc(0, 64)", InvalidArgument, [] { return aligned_alloc_nid_postfix(0, 64); });
expectNull("memalign(24, 64)", InvalidArgument, [] { return memalign_nid_postfix(24, 64); });
auto* block = static_cast<unsigned char*>(expectBlock("malloc(40)", [] { return malloc_nid_postfix(40); }));
if (block != nullptr) {
std::memset(block, 0x6b, 40);
expectNull("realloc(block, SIZE_MAX)", NoMemory, [block] { return realloc_nid_postfix(block, Max); });
expectNull("realloc(block, PTRDIFF_MAX + 1)", NoMemory, [block] { return realloc_nid_postfix(block, HalfPlusOne); });
for (unsigned index = 0; index < 40; ++index) {
if (block[index] != 0x6b) report("realloc failure", "damaged the original block");
}
free_nid_postfix(block);
}
#ifdef ANYPS5_ENABLE_ASAN
std::fputs("skipped: AddressSanitizer cannot map the shadow of a 300 GiB commit under a 128 MiB RLIMIT_DATA, so the failed commit and arena release checks did not run\n", stderr);
#else
if (GuestArena::GuestArenaAvailable_nid_postfix()) {
#ifdef __linux__
rlimit originalLimit{};
if (getrlimit(RLIMIT_DATA, &originalLimit) != 0) {
report("failed commit setup", "could not read RLIMIT_DATA");
return 1;
}
auto limited = originalLimit;
limited.rlim_cur = std::min(limited.rlim_cur, rlim_t{128} << 20);
if (setrlimit(RLIMIT_DATA, &limited) != 0) {
report("failed commit setup", "could not limit RLIMIT_DATA");
return 1;
}
#endif
constexpr std::size_t beyondCommitLimit = std::size_t{300} << 30;
constexpr std::size_t probeBytes = std::size_t{100} << 30;
void* before = GuestArena::GuestArenaAllocate_nid_postfix(probeBytes, 0x4000);
GuestArena::GuestArenaRelease_nid_postfix(before, probeBytes);
bool committed = false;
int failedCommits = 0;
for (int attempt = 0; attempt < 10 && !committed; ++attempt) {
*__error_nid_postfix() = 0;
void* huge = nullptr;
try {
huge = malloc_nid_postfix(beyondCommitLimit);
} catch (const std::exception& error) {
std::fprintf(stderr, "malloc(300 GiB): threw %s\n", error.what());
++failures;
break;
}
if (huge != nullptr) {
free_nid_postfix(huge);
committed = true;
} else if (*__error_nid_postfix() != NoMemory) {
report("malloc(300 GiB)", "returned NULL without ENOMEM");
} else {
++failedCommits;
}
}
#ifdef __linux__
if (setrlimit(RLIMIT_DATA, &originalLimit) != 0) report("failed commit cleanup", "could not restore RLIMIT_DATA");
#endif
if (committed) {
#ifdef __linux__
report("malloc(300 GiB)", "succeeded despite RLIMIT_DATA");
#else
std::fputs("skipped: the host can commit 300 GiB, so the failed commit and arena release checks did not run\n", stderr);
#endif
} else {
if (failedCommits != 10) report("failed heap commits", "did not return ENOMEM for all ten attempts");
void* after = nullptr;
try {
after = GuestArena::GuestArenaAllocate_nid_postfix(probeBytes, 0x4000);
GuestArena::GuestArenaRelease_nid_postfix(after, probeBytes);
} catch (const std::exception& error) {
std::fprintf(stderr, "failed commit range probe: %s\n", error.what());
++failures;
}
if (after != before) report("malloc(300 GiB)", "left its arena range reserved after failing");
std::fprintf(stderr, "Checked %d failed heap commits and arena range reuse\n", failedCommits);
}
void* small = malloc_nid_postfix(100);
if (small == nullptr) report("malloc(100) after a failed huge malloc", "returned NULL");
free_nid_postfix(small);
void* large = malloc_nid_postfix(std::size_t{1} << 20);
if (large == nullptr) report("malloc(1 MiB) after a failed huge malloc", "returned NULL");
free_nid_postfix(large);
}
#endif
void* untouched = &failures;
*__error_nid_postfix() = 77;
if (posix_memalign_nid_postfix(&untouched, HalfPlusOne, 8) != NoMemory) report("posix_memalign(PTRDIFF_MAX + 1)", "did not return ENOMEM");
if (posix_memalign_nid_postfix(&untouched, 64, HalfPlusOne) != NoMemory) report("posix_memalign(64, PTRDIFF_MAX + 1)", "did not return ENOMEM");
if (posix_memalign_nid_postfix(&untouched, 64, Max) != NoMemory) report("posix_memalign(64, SIZE_MAX)", "did not return ENOMEM");
if (untouched != &failures || *__error_nid_postfix() != 77) report("posix_memalign failure", "touched the output or errno");
free_nid_postfix(expectBlock("calloc(3, 5)", [] { return calloc_nid_postfix(3, 5); }));
free_nid_postfix(expectBlock("calloc(0, 5)", [] { return calloc_nid_postfix(0, 5); }));
free_nid_postfix(expectBlock("aligned_alloc(128, 1)", [] { return aligned_alloc_nid_postfix(128, 1); }));
free_nid_postfix(expectBlock("memalign(4096, 1)", [] { return memalign_nid_postfix(4096, 1); }));
void* first = expectBlock("malloc(0)", [] { return malloc_nid_postfix(0); });
void* second = expectBlock("malloc(0)", [] { return malloc_nid_postfix(0); });
if (first != nullptr && first == second) report("malloc(0)", "returned the same block twice");
free_nid_postfix(first);
free_nid_postfix(second);
return failures == 0 ? 0 : 1;
}