mirror of
https://github.com/Klipper4FlashForge/firmware.git
synced 2026-10-19 03:49:50 -05:00
Drop the four SDCARD_* calls: nothing left to clear
They cleared per-job state that FlashForge's virtual_sdcard fork carried over
from the last touchscreen job -- a stale `refuelling` flag, FFM, and the two
"print this job on another extruder" remap flags. We ship the upstream
virtual_sdcard (KLIPPER_FORK branch creator5), which has none of that state:
refuelling, change_filament, enable_ffm, need_check_ex, no_filament_check and
print_channel are all absent from its 308 lines, against the fork's 617. The
commands that cleared them are absent too.
They were never breaking anything. Klipper's cmd_default ends in
respond_info('Unknown command:"%s"'), not a raise, so all four were console
noise at the start of every Mainsail print and no more. Removing them rather
than shimming them: there is no state to shim.
The docs/notes references stay -- they describe FlashForge's fork, which is
still what they say it is.
SDCARD_SET_CHANNEL in ff_toolchange.py is the same case and still carries its
FIXME; left for a separate change since it sits on the toolchange path.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
86be9462b4
commit
848db028d0
1 file changed
+3
-9
@@ -447,15 +447,9 @@ gcode:
|
||||
; as the old SDCARD_PRINT_FILE
|
||||
; wrapper did. START_PRINT calls
|
||||
; it again with the tool list.
|
||||
; These four clear per-job state that FlashForge's virtual_sdcard fork
|
||||
; carried over from the last touchscreen job (a stale `refuelling`
|
||||
; flag, FFM, and the two "print this job on another extruder" remap
|
||||
; flags). Those commands exist only in the fork; on the upstream
|
||||
; virtual_sdcard we now ship they are unknown commands. FIXME.
|
||||
SDCARD_CLEAR_REFUELLING
|
||||
SDCARD_ENABLE_FFM ENABLE=0
|
||||
SDCARD_SET_NEED_CHECK_EX CHECK=0
|
||||
SDCARD_NO_FILAMENT_CHECK_EX CHECK=0
|
||||
; No per-job flags to clear: the refuelling / FFM / extruder-remap
|
||||
; state the touchscreen carried between jobs lived in FlashForge's
|
||||
; virtual_sdcard, and we ship the upstream one, which has none of it.
|
||||
SET_GCODE_VARIABLE MACRO=_FF_JOB VARIABLE=mainsail VALUE=1
|
||||
{% endif %}
|
||||
{% if not me.prepare %}
|
||||
|
||||
Reference in new issue
Block a user