From 99b3abb7a0d8d4766163feeabecb341d4e6a4983 Mon Sep 17 00:00:00 2001 From: James Smith Date: Wed, 14 Jan 2026 13:03:01 +0000 Subject: [PATCH] use instanceof instead of LoaderClass comparison in renderer --- app/javascript/offscreen_renderer.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/javascript/offscreen_renderer.ts b/app/javascript/offscreen_renderer.ts index ed79a9048..209b8574d 100644 --- a/app/javascript/offscreen_renderer.ts +++ b/app/javascript/offscreen_renderer.ts @@ -116,17 +116,17 @@ export class OffscreenRenderer { // Create loader const loader = new LoaderClass() // Set up DRACO loader for GLTF - if (LoaderClass === GLTFLoader) { + if (loader instanceof GLTFLoader) { const dracoLoader = new DRACOLoader() dracoLoader.setDecoderPath('https://www.gstatic.com/draco/versioned/decoders/1.5.7/') loader.setDRACOLoader(dracoLoader) - } else if (LoaderClass === DRACOLoader) { + } else if (loader instanceof DRACOLoader) { loader.setDecoderPath('https://www.gstatic.com/draco/versioned/decoders/1.5.7/') - } else if (LoaderClass === LDrawLoader) { + } else if (loader instanceof LDrawLoader) { loader.setConditionalLineMaterial(LDrawConditionalLineMaterial) loader.setPartsLibraryPath('https://raw.githubusercontent.com/gkjohnson/ldraw-parts-library/master/complete/ldraw/') await loader.preloadMaterials('https://raw.githubusercontent.com/gkjohnson/ldraw-parts-library/master/complete/ldraw/LDConfig.ldr') - } else if (LoaderClass === Rhino3dmLoader) { + } else if (loader instanceof Rhino3dmLoader) { loader.setLibraryPath('https://cdn.jsdelivr.net/npm/rhino3dm@8.17.0/') } // Load