From dca15404ec875670232d516632df40d7bb677dfd Mon Sep 17 00:00:00 2001 From: James Smith Date: Thu, 22 Jan 2026 22:57:37 +0000 Subject: [PATCH] send notifications to all new memberships --- app/controllers/groups_controller.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb index 22cd68203..8b762e8d1 100644 --- a/app/controllers/groups_controller.rb +++ b/app/controllers/groups_controller.rb @@ -57,7 +57,9 @@ class GroupsController < ApplicationController end def update + previous_membership_ids = @group.memberships.pluck(:id) @group.update group_params + @new_memberships = @group.reload.memberships.where.not(id: previous_membership_ids) respond_to do |format| format.html do if @group.valid? @@ -88,9 +90,9 @@ class GroupsController < ApplicationController def send_notifications if @group.valid? - NewGroupMemberNotifier.with(membership: Membership.last).deliver( - policy_scope(User).where(id: group_params[:memberships_attributes].to_h.filter_map { |k, v| v[:user_id] }) - ) + @new_memberships&.each do |it| + NewGroupMemberNotifier.with(membership: it).deliver(it.user) + end end end