onyx/web/tests/e2e/admin/disable_default_agent.spec.ts

import { test, expect, Page } from "@playwright/test";
import { ADMIN_ROUTES } from "@/lib/admin-routes";
import { loginAs } from "@tests/e2e/utils/auth";
import { createAgent } from "@tests/e2e/utils/agentUtils";
import { OnyxApiClient } from "@tests/e2e/utils/onyxApiClient";

const MAX_SETTING_SAVE_ATTEMPTS = 5;
const SETTING_SAVE_RETRY_DELAY_MS = 750;

/**
 * Expand the "Advanced Options" collapsible section on the Chat Preferences page.
 * The section is closed by default (`defaultOpen={false}`).
 * Only expands if not already open (checks for the switch element visibility).
 */
async function expandAdvancedOptions(page: Page): Promise<void> {
  // Wait for the page title to be visible, signalling the form has loaded
  await expect(page.locator('[aria-label="admin-page-title"]')).toBeVisible({
    timeout: 10000,
  });

  // Check if the switch is already visible (section already expanded)
  const switchEl = page.locator("#disable_default_assistant");
  const alreadyVisible = await switchEl.isVisible().catch(() => false);
  if (alreadyVisible) return;

  const header = page.getByText("Advanced Options", { exact: true });
  await expect(header).toBeVisible({ timeout: 10000 });
  await header.scrollIntoViewIfNeeded();
  await header.click();

  // Wait for the collapsible content to expand and switch to appear
  await expect(switchEl).toBeVisible({ timeout: 5000 });
}

/**
 * Toggle the "Always Start with an Agent" setting on the Chat Preferences page.
 * Uses auto-save via the SwitchField.
 *
 * The switch is a SwitchField with name="disable_default_assistant" which renders
 * `<button role="switch" id="disable_default_assistant" aria-checked="...">`.
 */
async function setDisableDefaultAssistantSetting(
  page: Page,
  isDisabled: boolean
): Promise<void> {
  let lastCheckedState = false;

  for (let attempt = 0; attempt < MAX_SETTING_SAVE_ATTEMPTS; attempt += 1) {
    await page.goto(ADMIN_ROUTES.CHAT_PREFERENCES.path);
    await page.waitForLoadState("networkidle");

    // Expand "Advanced Options" collapsible (closed by default)
    await expandAdvancedOptions(page);

    const switchEl = page.locator("#disable_default_assistant");
    await expect(switchEl).toBeVisible({ timeout: 5000 });

    const currentState = await switchEl.getAttribute("aria-checked");
    lastCheckedState = currentState === "true";

    if (lastCheckedState === isDisabled) {
      return;
    }

    // Toggle the switch and wait for the auto-save
    const saved = page.waitForResponse(
      (response) =>
        new URL(response.url()).pathname === "/api/admin/settings" &&
        response.request().method() === "PATCH"
    );
    await switchEl.click();
    expect((await saved).ok()).toBeTruthy();

    await page.waitForTimeout(SETTING_SAVE_RETRY_DELAY_MS);

    // Verify persistence after reload
    await page.reload();
    await page.waitForLoadState("networkidle");

    // Re-expand Advanced Options (closed by default after reload)
    await expandAdvancedOptions(page);

    const newState = await switchEl.getAttribute("aria-checked");
    lastCheckedState = newState === "true";

    if (lastCheckedState === isDisabled) {
      return;
    }
  }

  throw new Error(
    `Failed to persist Always Start with an Agent setting after ${MAX_SETTING_SAVE_ATTEMPTS} attempts (expected ${isDisabled}, last=${lastCheckedState}).`
  );
}

test.describe("Disable Default Agent Setting @exclusive", () => {
  let createdAssistantId: number | null = null;

  test.beforeEach(async ({ page }) => {
    // Log in as admin
    await page.context().clearCookies();
    await loginAs(page, "admin");
  });

  test.afterEach(async ({ page }) => {
    // Clean up any assistant created during the test
    if (createdAssistantId !== null) {
      const client = new OnyxApiClient(page.request);
      await client.deleteAgent(createdAssistantId);
      createdAssistantId = null;
    }

    // Ensure default agent is enabled (switch unchecked) after each test
    // to avoid interfering with other tests
    await setDisableDefaultAssistantSetting(page, false);
  });

  test("admin can enable and disable the setting in chat preferences", async ({
    page,
  }) => {
    await setDisableDefaultAssistantSetting(page, true);
    await setDisableDefaultAssistantSetting(page, false);
    await setDisableDefaultAssistantSetting(page, true);
  });

  test("new session button uses current agent when setting is enabled", async ({
    page,
  }) => {
    // Create the agent before enabling the setting, not after. With the setting
    // on and nothing but the default agent available, there is no agent to chat
    // with and /app correctly refuses to render one - which puts the UI that
    // creates agents out of reach.
    await page.goto("/app");
    const agentName = `Test Assistant ${Date.now()}`;
    await createAgent(page, {
      name: agentName,
      description: "Test assistant for new session button test",
      instructions: "You are a helpful test assistant.",
    });

    // Extract the assistant ID from the URL
    const currentUrl = page.url();
    const agentIdMatch = currentUrl.match(/agentId=(\d+)/);
    expect(agentIdMatch).toBeTruthy();

    // Store for cleanup
    if (agentIdMatch) {
      createdAssistantId = Number(agentIdMatch[1]);
    }

    await setDisableDefaultAssistantSetting(page, true);

    // The helper leaves the browser on the admin page, which has no app sidebar.
    await page.goto("/app");

    // Click the "New Session" button
    const newSessionButton = page.locator(
      '[data-testid="AppSidebar/new-session"]'
    );
    await newSessionButton.click();

    // Verify the WelcomeMessage shown is NOT from the default agent
    // Default agent shows onyx-logo, custom agents show agent-name-display
    await expect(page.locator('[data-testid="onyx-logo"]')).not.toBeVisible();
    await expect(
      page.locator('[data-testid="agent-name-display"]')
    ).toBeVisible();
  });

  test("direct navigation to /app uses first pinned assistant when setting is enabled", async ({
    page,
  }) => {
    // First enable the setting
    await setDisableDefaultAssistantSetting(page, true);

    // Navigate directly to /app
    await page.goto("/app");

    // Verify that we didn't land on the default agent (ID 0)
    // The assistant selection should be a pinned or available assistant (not ID 0)
    const currentUrl = page.url();
    // If agentId is in URL, it should not be 0
    if (currentUrl.includes("agentId=")) {
      expect(currentUrl).not.toContain("agentId=0");
    }
  });

  test("chat preferences shows disabled state when setting is enabled", async ({
    page,
  }) => {
    // First enable the setting
    await setDisableDefaultAssistantSetting(page, true);

    // Navigate to chat preferences configuration page
    await page.goto(ADMIN_ROUTES.CHAT_PREFERENCES.path);
    await page.waitForLoadState("networkidle");

    // Wait for the page to fully render (page title signals form is loaded)
    await expect(page.locator('[aria-label="admin-page-title"]')).toHaveText(
      /^Chat Preferences/,
      { timeout: 10000 }
    );

    // The new page wraps Connectors + Actions & Tools in <Disabled disabled={values.disable_default_assistant}>
    // When disabled, the section should have reduced opacity / disabled styling
    // The "Modify Prompt" button should still be accessible (it's outside the Disabled wrapper)
    // Use text locator (Opal Button wraps text in Interactive.Base > Slot which may
    // not expose role="button" to Playwright's getByRole)
    await expect(page.getByText("Modify Prompt")).toBeVisible({
      timeout: 5000,
    });

    // The "Actions & Tools" section text should still be present but visually disabled
    await expect(page.getByText("Actions & Tools")).toBeVisible();
  });

  test("chat preferences shows full configuration UI when setting is disabled", async ({
    page,
  }) => {
    // Ensure setting is disabled
    await setDisableDefaultAssistantSetting(page, false);

    // Navigate to chat preferences configuration page
    await page.goto(ADMIN_ROUTES.CHAT_PREFERENCES.path);
    await page.waitForLoadState("networkidle");

    // Verify configuration UI is shown (Actions & Tools section should be visible and enabled)
    await expect(page.getByText("Actions & Tools")).toBeVisible({
      timeout: 10000,
    });

    // Verify the page title
    await expect(page.locator('[aria-label="admin-page-title"]')).toHaveText(
      /^Chat Preferences/
    );
  });

  test("default agent is available again when setting is disabled", async ({
    page,
  }) => {
    // Navigate to settings and ensure setting is disabled
    await setDisableDefaultAssistantSetting(page, false);

    // Navigate directly to /app without parameters
    await page.goto("/app");

    // The default agent (ID 0) should be available
    // We can verify this by checking that the app loads successfully
    // and doesn't force navigation to a specific assistant
    expect(page.url()).toContain("/app");

    // Verify the new session button navigates to /app without agentId
    const newSessionButton = page.locator(
      '[data-testid="AppSidebar/new-session"]'
    );
    await newSessionButton.click();

    // Should navigate to /app without agentId parameter
    const newUrl = page.url();
    expect(newUrl).toContain("/app");
  });
});