mirror of
https://github.com/onyx-dot-app/onyx.git
synced 2026-10-21 11:00:28 -05:00
Wenxi
5858a6767e
## Description Use one decision endpoint for Approve once, Approve for session, and Reject. Concurrent session approvals lock the session before updating requests to prevent conflicting lock order. Keep approval outcomes available after decisions and reloads as compact, neutral conversation rows. Details start collapsed. Expired rows state that the action did not run; only pending requests show an attention border and decision buttons. The server decides whether a request is still live; a user's device clock cannot disable it. History includes live requests and the 50 most recent outcomes. Polls read small status records and refresh full history when statuses change. The proxy still waits up to 180 seconds. This is a network wait, not durable paused execution. Expired requests show Expired, and late decisions return a conflict. Agent permission requests that cannot resume fail scheduled runs with a clear reason. Losing an execution lease aborts the agent. The plugin editors and personal/task permission controls are in the preceding PR, #16185. Approval queries remain in the existing Craft DB module, as requested for this feature. ## How Has This Been Tested? - Ten approval-card/history tests pass, including collapsed neutral expiry, detail expansion, and live-request controls. - A browser check confirmed the neutral expired row and unchanged pending controls. - 82 gate unit tests passed after restoring the Craft DB module. - Earlier verification passed 21 approval API database tests, including concurrent session grants, retries, conflicting decisions, history, and expiry. - Earlier local Kind checks covered concurrent grants, a browser clock ten minutes ahead, and approved history after reload. - A scheduled worker requested approval without an open browser; approval resumed execution and produced the expected result. - An actual 180-second timeout blocked forwarding and rejected a late decision. - Follow-up verification passed 39 approval/executor database tests, 550 proxy unit tests, and five route-contract tests. ## Additional Options - [ ] [Optional] Please cherry-pick this PR to the latest release version. - [x] [Optional] Override Linear Check <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Approval cards now offer **Approve once**, **Approve for session**, and **Reject** in one flow, with session-wide approval available when eligible. * Session approval history now shows pending, approved, rejected, and expired requests. Status updates are checked automatically, and changed statuses refresh the history. * Cards show approval deadlines and present completed requests as compact, expandable outcomes. * **Bug Fixes** * Scheduled runs that need unavailable permissions now finish as failed runs instead of waiting for approval. * Expired approval messages clarify that the action did not run. <!-- end of auto-generated comment: release notes by coderabbit.ai -->