From df2039b1e132016f593d3fb164ae4cbff83c08c8 Mon Sep 17 00:00:00 2001 From: Alexey Cluster Date: Sun, 27 Sep 2026 22:04:09 +0200 Subject: [PATCH] cloud_ca_bundle: fix stale references in comments The header pointed at a nonexistent cmake/EmbedCloudCaBundle.cmake, and connect_cloud() credited CloudSession::configure() with the verification flags that actually live in CloudSession::start(). --- include/obn/cloud_ca_bundle.hpp | 3 ++- src/agent.cpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/obn/cloud_ca_bundle.hpp b/include/obn/cloud_ca_bundle.hpp index 87b92c6..81bcc01 100644 --- a/include/obn/cloud_ca_bundle.hpp +++ b/include/obn/cloud_ca_bundle.hpp @@ -2,7 +2,8 @@ // A standard, Mozilla-derived root CA bundle (the same one curl.se // publishes at https://curl.se/ca/cacert.pem, vendored at -// resources/cacert.pem and compiled in by cmake/EmbedCloudCaBundle.cmake). +// resources/cacert.pem and compiled in by the top-level CMakeLists.txt via +// cmake/cloud_ca_bundle_data.cpp.in). // // Why this exists: on Windows, vcpkg's static OpenSSL build ships no // default trust store, so mosquitto has nothing to validate the cloud diff --git a/src/agent.cpp b/src/agent.cpp index 481a899..2736056 100644 --- a/src/agent.cpp +++ b/src/agent.cpp @@ -2735,7 +2735,7 @@ int Agent::connect_cloud() // DigiCert Global Root G2) -- it needs a normal CA bundle, not // anything Bambu-specific. Write out the vendored bundle (see // cloud_ca_bundle.hpp) and use that, with full chain + hostname - // verification (CloudSession::configure() no longer skips either + // verification (CloudSession::start() no longer skips either // check now that this hands it a trust anchor that actually // validates the real chain). std::string cloud_ca;