mirror of
https://github.com/morluto/rea.git
synced 2026-10-22 13:52:32 -05:00
fix(cli): retain browser and Inspector input correction details (#2230)
Reuse the shared safe issue projection for all six CLI validation boundaries and cover malformed inputs, credential safety, and parser diagnostics. Fixes morluto/rea#2180 Developed with assistance from OpenAI Codex.
This commit is contained in:
1 parent
fd985dbc5b
commit
916ac97bf9
3 files changed
+247
-23
No files matched your search
@@ -12,7 +12,7 @@ import {
|
||||
listJavaScriptRuntimeTargetsInputSchema,
|
||||
observeJavaScriptRuntimeInputSchema,
|
||||
} from "./domain/javascript/javascriptRuntimeObservation.js";
|
||||
import { AnalysisInputError } from "./domain/analysisErrorCore.js";
|
||||
import { analysisInputErrorFromIssues } from "./domain/inputIssueProjection.js";
|
||||
import { projectAnalysisError } from "./domain/analysisErrorProjection.js";
|
||||
import type { JsonValue } from "./domain/jsonValue.js";
|
||||
import type { Logger } from "pino";
|
||||
@@ -47,11 +47,19 @@ export const registerJavaScriptRuntimeObservationCommands = (
|
||||
CLI_COMMANDS.listJavaScriptRuntimeTargets,
|
||||
async () => {
|
||||
const context = runtimeContext();
|
||||
const parsed = listJavaScriptRuntimeTargetsInputSchema.safeParse({
|
||||
const input = {
|
||||
inspector_endpoint: args.endpoint,
|
||||
});
|
||||
};
|
||||
const parsed =
|
||||
listJavaScriptRuntimeTargetsInputSchema.safeParse(input);
|
||||
if (!parsed.success)
|
||||
return inputError("list_javascript_runtime_targets");
|
||||
return cliError(
|
||||
analysisInputErrorFromIssues(
|
||||
"list_javascript_runtime_targets",
|
||||
parsed.error.issues,
|
||||
input,
|
||||
),
|
||||
);
|
||||
const result = await listJavaScriptRuntimeTargets(
|
||||
context.provider,
|
||||
parsed.data,
|
||||
@@ -73,13 +81,21 @@ export const registerJavaScriptRuntimeObservationCommands = (
|
||||
run: ({ args, options }) =>
|
||||
logCliCommand(logger, CLI_COMMANDS.observeJavaScriptRuntime, async () => {
|
||||
const context = runtimeContext();
|
||||
const parsed = observeJavaScriptRuntimeInputSchema.safeParse({
|
||||
const input = {
|
||||
inspector_endpoint: args.endpoint,
|
||||
target_id: args.targetId,
|
||||
runtime_kind: options.runtimeKind,
|
||||
observation_ms: options.observationMs,
|
||||
});
|
||||
if (!parsed.success) return inputError("observe_javascript_runtime");
|
||||
};
|
||||
const parsed = observeJavaScriptRuntimeInputSchema.safeParse(input);
|
||||
if (!parsed.success)
|
||||
return cliError(
|
||||
analysisInputErrorFromIssues(
|
||||
"observe_javascript_runtime",
|
||||
parsed.error.issues,
|
||||
input,
|
||||
),
|
||||
);
|
||||
const result = await observeJavaScriptRuntime(
|
||||
context.provider,
|
||||
parsed.data,
|
||||
@@ -93,9 +109,6 @@ const runtimeContext = () => ({
|
||||
provider: createJavaScriptRuntimeObservationProvider(),
|
||||
});
|
||||
|
||||
const inputError = (operation: string): JsonValue =>
|
||||
cliError(new AnalysisInputError(operation));
|
||||
|
||||
const cliError = (
|
||||
error: Parameters<typeof projectAnalysisError>[0],
|
||||
): JsonValue => ({
|
||||
|
||||
Reference in new issue
Block a user