Files
rea/scripts/verify-real-cutter.mjs
T
4aa51bfe19 fix(reverse): reconcile cleanup ownership and mutation diagnostics (#2799)
* feat(process): add owned debugger shutdown lifecycle

* feat(reverse): add local inspection commands

* feat(gdb): add persistent debugger integration

* feat(cutter): add Cutter bridge integration

* test(reverse): enforce complete integration coverage

* fix(process): preserve debugger shutdown ownership

* fix(reverse): retain evidence across interrupted commands

* fix(gdb): honor captured provider environment

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* test(process): cover debugger shutdown retries

* fix(reverse): retain evidence for interrupted providers

* fix(server): snapshot provider environment at creation

* fix(reverse): close review gaps with complete coverage

* fix(reverse): address inspection review findings

* fix(gdb): bound sessions and retain cleanup ownership

* fix(ci): require reverse-tools quality lane

* fix(process): unref inherited debugger output pipes

* fix(reverse): address remaining PR 1960 findings

* fix(gdb): address remaining PR 1961 findings

* fix(reverse): account for unrestricted provider execution

* fix(process): retain debugger ownership until safe shutdown

* fix(process): preserve replacement debugger sessions

* fix(reverse): preserve admission and output provenance

* fix(process): retain exited debugger until output settles

* fix(mcp): bound provider admission and debugger cleanup

* fix(reverse): preserve failure provenance and classify E2BIG

* fix(gdb): preserve startup cleanup and detach safety

* fix(process): retain debugger ownership after detach failure

* fix(reverse): preserve mutation and failure provenance

* fix(gdb): address debugger review findings

* fix(reverse): rebind sessions after external mutation

* fix(process): cap debugger output after exit

* fix(gdb): protect one-shot detach verification

* feat(debugger): add reverse tool coverage gate

* test(debugger): cover integrated failure paths

* fix(gdb): bound and preserve session observations

* fix(gdb): address review regressions

* style: format merged integration files

* fix(reverse): preserve session and output evidence

* refactor(gdb): share repeated test and partial result setup

* fix(gdb): invalidate TTY proof for Python aliases

* fix(reverse): retain failure output byte counts

* test(process): synchronize late debugger output

* fix(gdb): invalidate TTY proof for wrapped commands

* fix(gdb): recognize wit command abbreviation

* test(reverse): wait for cancelled descendant readiness

* test(reverse): bound descendant cancellation cleanup

* style(reverse): format integration tests and adapters

* style: format reverse engineering integration files

* test(reverse): remove duplicate environment harness

* test(gdb): share session startup assertions

* fix(gdb): invalidate output proof for command abbreviations

* test(reverse): share composition edge case scenarios

* fix(ci): recognize verification and mutation tool entries

* test(rizin): cover successful fake inferior detach

* test(cli): align full output failure envelope

* test(cli): isolate reverse command lifecycle service

* test(process): share debugger output fixture setup

* fix(binary): preserve high-bit Windows signature bytes

* style(binary): format Windows signature parser

* test(mcp): preserve call coverage in unchanged comparison

* fix(ci): include reverse tools Vitest configs in lint cache

* fix(mcp): preserve target content on delivery errors

* ci: align duplication ceiling with expanded suite

* test(reverse): allow signal admission mutants

* fix(reverse): bound retained cleanup failures to process owners

* fix(test): replace drifting mutation ranges with owned selectors

* fix(reverse): admit persistent commands and retain cleanup ownership

* fix(cutter): recover timed-out commands from exact receipts

* fix(cutter): reject unsupported bridge request kinds

* fix(ci): repair client format and shared verification fixtures

* fix(native): preserve debugger cleanup ownership and bridge authentication

* test(native): retain diagnostics without perfect coverage requirements

* chore(licenses): refresh locked dependency inventory and notices

* fix(test): exclude transient command locks from mutation sandboxes

* fix(gdb): admit only platforms with safe detach verification

* fix(cutter): retain bounded completion receipts until acknowledgement

* fix(cutter): acknowledge commands rejected before UI dispatch

* test(reverse): fail cancellation checks before fixture teardown

* test(gdb): clean up the retained broken-stdin fixture owner

* docs(test): clarify focused provider verification scope

* fix(rizin): retain close cleanup failures

* fix(gdb): wait for inferior stop and bound MI buffering

* fix(cutter): retain failed receipt acknowledgements

* fix(rizin): return retained session identity on rebind failure

* fix(gdb): preserve startup cancellation and lossy status

* fix(rizin): retain launch provenance and assemble frames once

* fix(cutter): recover receipts across callers and bound discovery

* docs: describe debugger evidence and bridge recovery

* fix(process): keep cleanup incomplete while writers remain

Stopping a debugger no longer reports success when inherited output
streams stay open, so BinarySession cannot reopen a binary a child is
still changing. Concurrent Cutter cleanup retries share one receipt
acknowledgement instead of treating a consumed receipt as failure.

* fix(debuggers): recover cleanup with captured process identities

* fix(analysis): retire sessions after unrestricted commands

* fix(cli): preserve completed evidence after cleanup recovery

* fix(cutter): bound frame collection and coalesce cleanup

* fix(windows): resolve selected provider paths absolutely

* fix(gdb): report decoding loss in failed startup evidence

* fix(rizin): scope decoding loss to collected command frames

* test(mcp): cover snapshot retirement in reverse tools CI

---------

Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com>
Co-authored-by: REA Maintainers <noreply@github.com>
Co-authored-by: OpenAI Codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
2026-10-14 04:47:34 +08:00

215 lines
6.1 KiB
JavaScript

#!/usr/bin/env node
import assert from "node:assert/strict";
import { Client, InMemoryTransport } from "@modelcontextprotocol/client";
import { execFile } from "node:child_process";
import { createHash, randomUUID } from "node:crypto";
import {
access,
constants,
mkdtemp,
readFile,
rm,
writeFile,
} from "node:fs/promises";
import { tmpdir } from "node:os";
import { join, resolve } from "node:path";
import { promisify } from "node:util";
import { createServer } from "../dist/server/createServer.js";
const execFileAsync = promisify(execFile);
const cli = resolve("scripts/rea.mjs");
const runCli = async (...arguments_) => {
const { stdout } = await execFileAsync(
process.execPath,
[cli, ...arguments_, "--format", "json"],
{
encoding: "utf8",
maxBuffer: 4 * 1024 * 1024,
env: process.env,
},
);
return JSON.parse(stdout);
};
const projectRoot = await mkdtemp(join(tmpdir(), "rea-cutter-smoke-"));
const projectPath = join(projectRoot, "smoke.rzdb");
const rizinQuote = (value) =>
`"${value.replaceAll("\\", "\\\\").replaceAll('"', '\\"')}"`;
const unavailableAnalysis = {
execute: async () => {
throw new Error(
"The Cutter verification does not call unrelated analysis tools.",
);
},
};
const expectedPlatform = {
Linux: "linux",
macOS: "darwin",
Windows: "win32",
}[process.env.EXPECTED_PLATFORM];
if (expectedPlatform !== undefined)
assert.equal(
process.platform,
expectedPlatform,
"Cutter runner did not match its declared platform.",
);
try {
const discovery = await runCli("list-cutter-sessions");
assert.equal(
discovery.discovery_status,
"sessions_found",
"Open upstream Cutter with the REA plugin before running this smoke test.",
);
assert.ok(discovery.sessions.length > 0);
const session = discovery.sessions[0];
assert.ok(session);
assert.ok(
session.cutter_version,
"The upstream Cutter API did not report its version.",
);
if (process.env.REA_CUTTER_EXPECTED_VERSION !== undefined)
assert.ok(
session.cutter_version.includes(process.env.REA_CUTTER_EXPECTED_VERSION),
"The live Cutter version did not match the configured version.",
);
assert.ok(
session.current_file,
"Open a disposable local binary in Cutter before running this smoke test.",
);
const artifactPath = session.current_file;
const artifactDigest = createHash("sha256")
.update(await readFile(artifactPath))
.digest("hex");
const inspection = await runCli(
"cutter-command",
session.session_id,
String(session.document_generation),
"ij",
"--json",
);
assert.equal(inspection.predicate_type, "rea.cutter.command-observation");
assert.ok(
Object.hasOwn(inspection, "raw_result"),
"Cutter ij result was not retained as Evidence.",
);
assert.equal(typeof inspection.raw_result.bin?.arch, "string");
const mcpServer = createServer(
{ kind: "fixed", analysis: unavailableAnalysis },
{
providerEnvironment: process.env,
},
);
const mcpClient = new Client({
name: "rea-cutter-upstream-smoke",
version: "1",
});
const [clientTransport, serverTransport] =
InMemoryTransport.createLinkedPair();
try {
await mcpServer.connect(serverTransport);
await mcpClient.connect(clientTransport);
const mcpDiscovery = await mcpClient.callTool({
name: "list_cutter_sessions",
arguments: {},
});
assert.notEqual(mcpDiscovery.isError, true);
assert.equal(
mcpDiscovery.structuredContent.discovery_status,
"sessions_found",
);
const mcpInspection = await mcpClient.callTool({
name: "cutter_command",
arguments: {
session_id: session.session_id,
expected_generation: session.document_generation,
command: "ij",
json: true,
},
});
assert.notEqual(mcpInspection.isError, true);
assert.deepEqual(
mcpInspection.structuredContent.normalized_result,
inspection.normalized_result,
"Cutter CLI and MCP returned different analysis results.",
);
} finally {
await mcpClient.close();
await mcpServer.close();
}
const annotation = `rea-smoke-${randomUUID()}`;
await runCli(
"cutter-command",
session.session_id,
String(session.document_generation),
`CC ${annotation} @ entry0`,
);
await runCli(
"cutter-command",
session.session_id,
String(session.document_generation),
`Ps ${rizinQuote(projectPath)}`,
);
await access(projectPath, constants.R_OK | constants.W_OK);
await runCli(
"cutter-command",
session.session_id,
String(session.document_generation),
"CC- @ entry0",
);
const removed = await runCli(
"cutter-command",
session.session_id,
String(session.document_generation),
"CC. @ entry0",
);
assert.ok(
!String(removed.raw_result).includes(annotation),
"The in-memory annotation was not removed before project reopening.",
);
await runCli(
"cutter-command",
session.session_id,
String(session.document_generation),
`Po ${rizinQuote(projectPath)}`,
);
const recovered = await runCli(
"cutter-command",
session.session_id,
String(session.document_generation),
"CC. @ entry0",
);
assert.equal(recovered.predicate_type, "rea.cutter.command-observation");
assert.ok(
String(recovered.raw_result).includes(annotation),
"The saved project did not preserve the analysis comment after reopening.",
);
const finalArtifactDigest = createHash("sha256")
.update(await readFile(artifactPath))
.digest("hex");
assert.equal(
finalArtifactDigest,
artifactDigest,
"Cutter project edits changed the executable bytes.",
);
const report = {
ok: true,
platform: process.platform,
cutter_version: session.cutter_version,
document_generation: session.document_generation,
cli_mcp_evidence_parity: true,
annotation_saved_and_reopened: true,
executable_digest_unchanged: true,
};
await writeFile("cutter-smoke.json", `${JSON.stringify(report, null, 2)}\n`, {
mode: 0o600,
});
console.log(JSON.stringify(report));
} finally {
await rm(projectRoot, { recursive: true, force: true });
}