mirror of
https://github.com/morluto/rea.git
synced 2026-10-23 06:12:29 -05:00
* refactor(test): colocate pure-domain tests and reduce test debt Move focused immutable domain/contracts/adapter tests from tests/composition/** beside their production owners under src/** as colocated *.test.ts/*.fixture.ts, and relocate persistence-shaped composition tests under tests/boundary/filesystem/**. Update import paths, the Vitest project topology (shared worker context for pure domain/contracts and recording-port service projects), the test migration ledger, testing docs, and AGENTS.md to match. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs: remove test migration ledger The cutover is complete and the ledger is no longer referenced anywhere in source, scripts, or the docs gate. Drop the standalone artifact. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs: clean up stale migration artifacts Remove empty directories left by the test migration and replace the "final cutover" language in docs/testing.md with standing PR guidance that no longer references the completed migration. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix: repair CI failures from schema, knip, and stale generated artifacts Three root causes fixed: 1. catalog-schemas.mjs: valuesAt only traversed anyOf from Zod's toJSONSchema, not oneOf. The webScreenshotDiffSchema change to a discriminated union produces oneOf, so the product catalog generator could not derive the web_screenshot_diff schema version. Add oneOf traversal. 2. conformancePackage.ts: the test rewrite removed the only imports of ScenarioManifest, ReplayPlan, ShimPlan, and ExpectedEvidence, making them unused exports that knip flags. Remove the dead type aliases. 3. Regenerate stale artifacts (product catalog, MCP tool catalog, skill metadata, conformance manifest) that drifted from the source changes. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
455 lines
14 KiB
TypeScript
455 lines
14 KiB
TypeScript
import { mkdir, writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
|
|
import { expect, it } from "vitest";
|
|
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
|
|
import { createElectronEvidence } from "../../../src/application/ElectronEvidence.js";
|
|
import { createElectronActiveEvidence } from "../../../src/application/ElectronActiveEvidence.js";
|
|
import { analyzeJavaScriptApplication } from "../../../src/application/JavaScriptApplicationService.js";
|
|
import { reconcileJavaScriptRuntime } from "../../../src/domain/javascriptRuntimeReconciliation.js";
|
|
import { javascriptRuntimeReconciliationResultSchema } from "../../../src/domain/javascriptRuntimeReconciliationSchemas.js";
|
|
import { electronActiveObservationInputSchema } from "../../../src/domain/electronActiveObservation.js";
|
|
import { inspectElectronPageInputSchema } from "../../../src/domain/electronObservation.js";
|
|
import { createWebTextArtifact } from "../../../src/domain/webContentArtifact.js";
|
|
import { permissionAuthorityForRoot } from "../../fixtures/permissionAuthority.js";
|
|
import { createElectronActiveObservationFixtureResult } from "../../fixtures/electronActiveObservationResult.js";
|
|
|
|
const SOURCE = `const worker = new Worker("./worker.js");\nexport const observed = worker;\n`;
|
|
|
|
it("matches renderer, frame, script bytes, and worker without claiming execution", async () => {
|
|
const fixture = await applicationFixture();
|
|
const staticEvidence = await analyzeFixture(fixture);
|
|
const runtimeEvidence = electronRuntimeEvidence(fixture, SOURCE);
|
|
|
|
const result = reconcileJavaScriptRuntime({
|
|
static_layers: [{ role: "application", analysis: staticEvidence }],
|
|
runtime_observations: [runtimeEvidence],
|
|
});
|
|
|
|
expect(() =>
|
|
javascriptRuntimeReconciliationResultSchema.parse(result),
|
|
).not.toThrow();
|
|
expect(result.summary).toMatchObject({
|
|
runtime_targets: 1,
|
|
runtime_frames: 1,
|
|
runtime_scripts: 1,
|
|
runtime_workers: 1,
|
|
matched: 2,
|
|
ambiguous: 2,
|
|
unmatched: 0,
|
|
});
|
|
expect(result.reconciliations).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
entity_kind: "script",
|
|
status: "matched",
|
|
basis: "content-and-location",
|
|
}),
|
|
expect.objectContaining({
|
|
entity_kind: "worker",
|
|
status: "matched",
|
|
basis: "artifact-path",
|
|
}),
|
|
expect.objectContaining({
|
|
entity_kind: "target",
|
|
status: "ambiguous",
|
|
reason: "ambiguous-static-candidates",
|
|
}),
|
|
]),
|
|
);
|
|
const matched = result.reconciliations.find(
|
|
({ status }) => status === "matched",
|
|
);
|
|
if (matched === undefined)
|
|
throw new TypeError("Expected one matched runtime reconciliation");
|
|
expect(
|
|
javascriptRuntimeReconciliationResultSchema.safeParse({
|
|
...result,
|
|
reconciliations: [{ ...matched, static_node_id: null }],
|
|
}).success,
|
|
).toBe(false);
|
|
expect(result.static_load_states).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
kind: "javascript-asset",
|
|
status: "loaded",
|
|
}),
|
|
]),
|
|
);
|
|
expect(result.limitations.join(" ")).toMatch(
|
|
/not reported as executed|not code reachability/u,
|
|
);
|
|
expect(
|
|
result.graph.edges
|
|
.filter(({ relation }) => relation === "observed_as")
|
|
.every(
|
|
({ evidence }) =>
|
|
evidence.authority === "cross-layer-reconciliation" &&
|
|
evidence.state === "inferred",
|
|
),
|
|
).toBe(true);
|
|
const worker = result.reconciliations.find(
|
|
({ entity_kind: kind }) => kind === "worker",
|
|
);
|
|
const frame = result.reconciliations.find(
|
|
({ entity_kind: kind }) => kind === "frame",
|
|
);
|
|
expect(result.graph.edges).toContainEqual(
|
|
expect.objectContaining({
|
|
source_node_id: frame?.runtime_node_id,
|
|
target_node_id: worker?.runtime_node_id,
|
|
relation: "contains",
|
|
}),
|
|
);
|
|
});
|
|
|
|
it("reports a captured digest disagreement instead of accepting a path match", async () => {
|
|
const fixture = await applicationFixture();
|
|
const staticEvidence = await analyzeFixture(fixture);
|
|
const runtimeEvidence = electronRuntimeEvidence(
|
|
fixture,
|
|
"export const observed = 'different';\n",
|
|
);
|
|
|
|
const result = reconcileJavaScriptRuntime({
|
|
static_layers: [{ role: "application", analysis: staticEvidence }],
|
|
runtime_observations: [runtimeEvidence],
|
|
});
|
|
const script = result.reconciliations.find(
|
|
({ entity_kind: kind }) => kind === "script",
|
|
);
|
|
|
|
expect(script).toMatchObject({
|
|
status: "unmatched",
|
|
reason: "captured-content-disagrees-with-static-location",
|
|
});
|
|
expect(script?.candidate_static_nodes).toHaveLength(1);
|
|
});
|
|
|
|
it("keeps source-map declarations outside primary matching authority", async () => {
|
|
const fixture = await applicationFixture();
|
|
const staticEvidence = await analyzeFixture(fixture);
|
|
const runtimeEvidence = electronRuntimeEvidence(fixture, SOURCE);
|
|
const result = reconcileJavaScriptRuntime({
|
|
static_layers: [{ role: "application", analysis: staticEvidence }],
|
|
runtime_observations: [runtimeEvidence],
|
|
});
|
|
|
|
expect(result.source_map_authority).toMatchObject({
|
|
used_for_primary_matching: false,
|
|
static_layers_with_read_approval: 0,
|
|
runtime_script_declarations: 0,
|
|
});
|
|
});
|
|
|
|
it("reconciles active Electron as a partial target-only runtime capture", async () => {
|
|
const fixture = await applicationFixture();
|
|
const staticEvidence = await analyzeFixture(fixture);
|
|
const applicationPath = join(fixture, "main.js");
|
|
const input = electronActiveObservationInputSchema.parse({
|
|
schema_version: 1,
|
|
executable_path: process.execPath,
|
|
application_path: applicationPath,
|
|
application_root: fixture,
|
|
actions: [],
|
|
approved: true,
|
|
});
|
|
const runtimeEvidence = createElectronActiveEvidence(
|
|
input,
|
|
createElectronActiveObservationFixtureResult(applicationPath),
|
|
{
|
|
id: "rea-playwright-electron-active",
|
|
name: "REA Playwright active Electron observation provider",
|
|
version: "1",
|
|
},
|
|
);
|
|
|
|
const result = reconcileJavaScriptRuntime({
|
|
static_layers: [{ role: "application", analysis: staticEvidence }],
|
|
runtime_observations: [runtimeEvidence],
|
|
});
|
|
|
|
expect(result.runtime_captures).toMatchObject([
|
|
{
|
|
kind: "electron-active",
|
|
scripts: 0,
|
|
frames: 0,
|
|
workers: 0,
|
|
scripts_complete_within_scope: false,
|
|
},
|
|
]);
|
|
expect(result.coverage.status).toBe("partial");
|
|
expect(result.limitations.join(" ")).toMatch(
|
|
/incomplete|not reported as executed/u,
|
|
);
|
|
});
|
|
|
|
it("hashes the retained Electron scenario projection, not raw selectors or secrets", async () => {
|
|
const fixture = await applicationFixture();
|
|
const applicationPath = join(fixture, "main.js");
|
|
const makeInput = (secret: string, selector: string) =>
|
|
electronActiveObservationInputSchema.parse({
|
|
schema_version: 1,
|
|
executable_path: process.execPath,
|
|
application_path: applicationPath,
|
|
application_root: fixture,
|
|
args: ["--token", secret],
|
|
actions: [{ step_id: "click", kind: "click", selector }],
|
|
approved: true,
|
|
});
|
|
const provider = {
|
|
id: "rea-playwright-electron-active",
|
|
name: "REA Playwright active Electron observation provider",
|
|
version: "1",
|
|
};
|
|
const first = createElectronActiveEvidence(
|
|
makeInput("first-secret", "#first-secret"),
|
|
createElectronActiveObservationFixtureResult(applicationPath),
|
|
provider,
|
|
);
|
|
const second = createElectronActiveEvidence(
|
|
makeInput("second-secret", "#second-secret"),
|
|
createElectronActiveObservationFixtureResult(applicationPath),
|
|
provider,
|
|
);
|
|
|
|
expect(first.parameters.scenario_sha256).toBe(
|
|
second.parameters.scenario_sha256,
|
|
);
|
|
expect(JSON.stringify(first)).not.toContain("first-secret");
|
|
expect(JSON.stringify(first)).not.toContain("#first-secret");
|
|
expect(first.parameters.args).toEqual(["--token", "<redacted>"]);
|
|
});
|
|
|
|
it("imports an operator-provided cache layer through an explicit file mapping", async () => {
|
|
const application = await applicationFixture();
|
|
const cache = await createTestTempDirectory("rea-runtime-cache-static-");
|
|
const runtimeCache = await createTestTempDirectory("rea-runtime-cache-live-");
|
|
const cacheSource = "export const cachedFeature = 'fixture';\n";
|
|
await mkdir(join(cache, "mapped"));
|
|
await Promise.all([
|
|
writeFile(join(cache, "mapped", "chunk.js"), cacheSource),
|
|
writeFile(join(cache, "outside.js"), "export const outside = true;\n"),
|
|
writeFile(join(runtimeCache, "chunk.js"), cacheSource),
|
|
writeFile(join(runtimeCache, "index.html"), "<script></script>"),
|
|
]);
|
|
const applicationEvidence = await analyzeFixture(application);
|
|
const cacheEvidence = await analyzeFixture(cache);
|
|
const runtimeEvidence = electronRuntimeEvidence(runtimeCache, cacheSource, {
|
|
scriptFile: "chunk.js",
|
|
includeWorker: false,
|
|
});
|
|
|
|
const result = reconcileJavaScriptRuntime({
|
|
static_layers: [
|
|
{ role: "application", analysis: applicationEvidence },
|
|
{
|
|
role: "cache",
|
|
analysis: cacheEvidence,
|
|
runtime_mappings: [
|
|
{
|
|
kind: "file-root",
|
|
root: runtimeCache,
|
|
artifact_prefix: "mapped",
|
|
},
|
|
],
|
|
},
|
|
],
|
|
runtime_observations: [runtimeEvidence],
|
|
});
|
|
const script = result.reconciliations.find(
|
|
({ entity_kind: kind }) => kind === "script",
|
|
);
|
|
const cacheLayer = result.static_layers.find(({ role }) => role === "cache");
|
|
|
|
expect(script).toMatchObject({
|
|
status: "matched",
|
|
basis: "content-and-location",
|
|
static_layer_id: cacheLayer?.layer_id,
|
|
});
|
|
const outside = result.graph.nodes.find(
|
|
(node) =>
|
|
node.kind === "javascript-asset" &&
|
|
node.observations.some(
|
|
({ properties }) => properties.path === "outside.js",
|
|
),
|
|
);
|
|
expect(
|
|
result.static_load_states.find(
|
|
({ static_node_id: nodeId }) => nodeId === outside?.node_id,
|
|
),
|
|
).toMatchObject({
|
|
status: "unknown",
|
|
reason: "layer-outside-runtime-scope",
|
|
});
|
|
});
|
|
|
|
const applicationFixture = async (): Promise<string> => {
|
|
const root = await createTestTempDirectory("rea-runtime-reconciliation-");
|
|
await Promise.all([
|
|
writeFile(
|
|
join(root, "package.json"),
|
|
JSON.stringify({
|
|
name: "rea-runtime-reconciliation-fixture",
|
|
version: "1.0.0",
|
|
renderer: "index.html",
|
|
}),
|
|
),
|
|
writeFile(join(root, "index.html"), "<script src='./app.js'></script>"),
|
|
writeFile(join(root, "app.js"), SOURCE),
|
|
writeFile(join(root, "worker.js"), "self.onmessage = () => undefined;\n"),
|
|
]);
|
|
return root;
|
|
};
|
|
|
|
const analyzeFixture = async (root: string) => {
|
|
const authority = await permissionAuthorityForRoot(
|
|
root,
|
|
["investigation_input"],
|
|
["investigation_input"],
|
|
);
|
|
const result = await analyzeJavaScriptApplication(authority, {
|
|
input_path: root,
|
|
approved: true,
|
|
});
|
|
if (!result.ok) throw result.error;
|
|
return result.value;
|
|
};
|
|
|
|
const electronRuntimeEvidence = (
|
|
root: string,
|
|
source: string,
|
|
options: {
|
|
readonly scriptFile?: string;
|
|
readonly includeWorker?: boolean;
|
|
readonly targetId?: string;
|
|
readonly sourceCaptureApproved?: boolean;
|
|
readonly workersUnavailable?: boolean;
|
|
} = {},
|
|
) => {
|
|
const scriptFile = options.scriptFile ?? "app.js";
|
|
const includeWorker = options.includeWorker ?? true;
|
|
const targetId = options.targetId ?? "target-main";
|
|
const sourceCaptureApproved = options.sourceCaptureApproved ?? true;
|
|
const input = inspectElectronPageInputSchema.parse({
|
|
cdp_endpoint: "http://127.0.0.1:9223",
|
|
allowed_file_roots: [root],
|
|
target_id: targetId,
|
|
approved: true as const,
|
|
observation_ms: 100,
|
|
include_script_sources: sourceCaptureApproved,
|
|
source_capture_approved: sourceCaptureApproved,
|
|
limits: {
|
|
max_frames: 200,
|
|
max_dom_nodes: 2_000,
|
|
max_scripts: 500,
|
|
max_resources: 2_000,
|
|
max_workers: 500,
|
|
max_script_source_bytes: 1_048_576,
|
|
max_total_script_source_bytes: 4_194_304,
|
|
},
|
|
});
|
|
return createElectronEvidence(
|
|
"inspect_electron_page",
|
|
input,
|
|
{
|
|
schema_version: 1,
|
|
browser: {
|
|
product: "Electron/fixture",
|
|
protocol_version: "1.3",
|
|
revision: "fixture",
|
|
user_agent: "Electron fixture",
|
|
js_version: "13",
|
|
},
|
|
target: {
|
|
target_id: targetId,
|
|
type: "page",
|
|
title: "Fixture",
|
|
file_path: join(root, "index.html"),
|
|
attached: false,
|
|
},
|
|
capture_window: {
|
|
started_at: "2026-07-15T00:00:00.000Z",
|
|
ended_at: "2026-07-15T00:00:00.100Z",
|
|
observation_ms: 100,
|
|
},
|
|
completeness: options.workersUnavailable
|
|
? {
|
|
...completeCapture(),
|
|
status: "attach_limited" as const,
|
|
conditions: ["attach_limited" as const],
|
|
attach_limited_sections: ["workers" as const],
|
|
unavailable_sections: ["workers" as const],
|
|
}
|
|
: completeCapture(),
|
|
frames: [
|
|
{
|
|
frame_id: "frame-main",
|
|
parent_frame_id: null,
|
|
file_path: join(root, "index.html"),
|
|
},
|
|
],
|
|
dom: { total_nodes: 0, nodes: [] },
|
|
scripts: {
|
|
total: 1,
|
|
items: [
|
|
{
|
|
script_key: `electron_script_${"1".repeat(64)}`,
|
|
frame_id: "frame-main",
|
|
file_path: join(root, scriptFile),
|
|
cdp_hash: "fixture",
|
|
length: Buffer.byteLength(source),
|
|
is_module: true,
|
|
language: "JavaScript",
|
|
source: {
|
|
included: true as const,
|
|
artifact: createWebTextArtifact(source, "text/javascript"),
|
|
},
|
|
},
|
|
],
|
|
},
|
|
resources: [],
|
|
workers: includeWorker
|
|
? [
|
|
{
|
|
target_id: "worker-main",
|
|
type: "worker",
|
|
file_path: join(root, "worker.js"),
|
|
attached: false,
|
|
opener_target_id: targetId,
|
|
parent_frame_id: "frame-main",
|
|
},
|
|
]
|
|
: [],
|
|
limitations: ["Synthetic passive capture fixture."],
|
|
},
|
|
{
|
|
id: "rea-cdp-electron",
|
|
name: "REA Electron file-page CDP observation provider",
|
|
version: "1",
|
|
},
|
|
);
|
|
};
|
|
|
|
const completeCapture = () => ({
|
|
status: "complete_within_window" as const,
|
|
conditions: ["complete_within_window" as const],
|
|
policy_filtered_sections: [],
|
|
attach_limited_sections: [],
|
|
truncated_sections: [],
|
|
unavailable_sections: [],
|
|
excluded: [],
|
|
dropped_events: {
|
|
scripts: 0,
|
|
network_requests: 0,
|
|
console_events: 0,
|
|
websocket_connections: 0,
|
|
websocket_frames: 0,
|
|
webmcp_tools: 0,
|
|
timeline_events: 0,
|
|
total: 0,
|
|
},
|
|
});
|