From 72328ab521800dc610255ac7ab08f5de4e241c8d Mon Sep 17 00:00:00 2001 From: Max Murphy Date: Sun, 18 Oct 2026 22:37:59 +0200 Subject: [PATCH] cli: keep the non-UTF-8 file name test off macOS (#2993) * cli: keep the non-UTF-8 file name test off macOS APFS refuses file names that aren't valid UTF-8, so the fixture can't be made there (as in tests/non_utf8_args.rs); the unit test runs on the other unixes. * chore: add @maxm11 to About-window contributors with their own name --- apps/wordcraft-cli/src/main.rs | 4 +++- contributors/people.toml | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/wordcraft-cli/src/main.rs b/apps/wordcraft-cli/src/main.rs index b0eeef592..6c284a088 100644 --- a/apps/wordcraft-cli/src/main.rs +++ b/apps/wordcraft-cli/src/main.rs @@ -1125,7 +1125,9 @@ mod tests { assert!(!dir.join("a.docx").exists()); } - #[cfg(unix)] + /// APFS refuses file names that aren't valid UTF-8, so the fixture can't be made on macOS + /// (as in `tests/non_utf8_args.rs`). + #[cfg(all(unix, not(target_os = "macos")))] #[test] fn script_file_name_need_not_be_unicode() { use std::os::unix::ffi::OsStringExt; diff --git a/contributors/people.toml b/contributors/people.toml index 70f2d58b3..ffde17472 100644 --- a/contributors/people.toml +++ b/contributors/people.toml @@ -160,3 +160,6 @@ sync_github_name = true [people.lucAmbr0] sync_github_name = true + +[people.maxm11] +real_name = "Max Murphy"