Jorge Feitosa a8bda031f0 FLAC for the frontend's CHD reader, so achievements hash CD FLAC discs (0133) ...

From mihawk-99/PS5_RetroArch#50 (Jorge Feitosa), renumbered: 0131 and
0132 were taken. chdman lists CD FLAC among a CD's codecs by default,
and libchdr refuses a CHD that declares a codec it was built without, so
the frontend could not open such a disc to hash it for RetroAchievements
even where the core read it with its own copy of libchdr. RetroArch is
now configured with builtin FLAC; build-title.sh leaves out the one FLAC
define whose value is a string, which tools/build.sh cannot take as a
name and the title's sources do not use.

The CHD reader's FLAC codec decodes with dr_flac (deps/dr, public domain
or MIT-0). libFLAC is compiled into libretroarch.a, but nothing calls
it: the linked title holds no FLAC__ symbol and 51 drflac ones, so the
notices are unchanged.

Evidence:
- tests/test_chd_flac.py: the configure flags enable builtin FLAC; the
  vendored reader, compiled as Makefile.common compiles it with builtin
  FLAC, opens tests/chd/tone-cdfl.chd (synthetic: a second of a 440 Hz
  tone and silence, chdman 0.289 -c cdfl, 3,783 bytes) and decodes its
  75 frames to the generated PCM byte for byte; without FLAC it fails.
- Host, with a CHD chdman made from one of the owner's PlayStation
  backups (cdlz, cdzl, cdfl; 2,338 of 31,002 hunks CD FLAC): the reader
  from build/ra-conf answers "unsupported format" without FLAC, and with
  it opens the disc and reads all 31,002 hunks with their CRCs.
- Console, before this change (build 22b5d122, offline, a test user):
  Beetle PSX HW loads that CHD, and RetroArch's hash answers "Could not
  open track" for each of nine candidate consoles, then "hash generation
  failed". After: with this series' deploy.
Gates: format, unit (199), build (staged cores reused), integration,
evidence PASS.

2026-10-17 20:52:55 -04:00

..

tone-cdfl.chd

FLAC for the frontend's CHD reader, so achievements hash CD FLAC discs (0133)

2026-10-17 20:52:55 -04:00