mirror of
https://github.com/Donkie/Spoolman.git
synced 2026-10-21 09:39:46 -05:00
Donkie
72daa29cd2
Task 10: config.js JSON-encodes the base path, so a backslash cannot escape the string literal the way the old " check allowed; search.py escapes LIKE wildcards at both its call sites, using a helper moved into database/utils.py so it and extra_field_query share one implementation. Task 9 was a pair of decisions rather than fixes. /info keeps its paths: both clients render them and removing response fields breaks API v1, while the disclosure buys nothing against an API that is unauthenticated anyway. /metrics keeps its shape but now says what it publishes when switched on. Also pins the unit tests to a throwaway data directory -- importing spoolman.main creates one as a side effect, and it was the real one.
36 lines
1.2 KiB
Python
36 lines
1.2 KiB
Python
"""Tests for LIKE wildcard escaping in search patterns."""
|
|
|
|
import pytest
|
|
|
|
from spoolman.database.utils import LIKE_ESCAPE, escape_like
|
|
|
|
|
|
def test_percent_is_escaped():
|
|
"""Otherwise a search for "%" matches every row."""
|
|
assert escape_like("%") == f"{LIKE_ESCAPE}%"
|
|
|
|
|
|
def test_underscore_is_escaped():
|
|
"""Otherwise "PLA_Basic" also matches "PLAxBasic"."""
|
|
assert escape_like("PLA_Basic") == f"PLA{LIKE_ESCAPE}_Basic"
|
|
|
|
|
|
def test_the_escape_character_is_escaped_first():
|
|
"""A literal escape char must not turn the following character into an escaped one."""
|
|
assert escape_like(f"{LIKE_ESCAPE}%") == f"{LIKE_ESCAPE}{LIKE_ESCAPE}{LIKE_ESCAPE}%"
|
|
|
|
|
|
def test_ordinary_text_is_untouched():
|
|
assert escape_like("Prusament Galaxy Black") == "Prusament Galaxy Black"
|
|
|
|
|
|
@pytest.mark.parametrize("term", ["100% silk", "a_b", "%_%", LIKE_ESCAPE, ""])
|
|
def test_escaping_is_idempotent_in_meaning(term: str):
|
|
"""Escaping never drops characters; the pattern only ever grows."""
|
|
assert len(escape_like(term)) >= len(term)
|
|
|
|
|
|
def test_the_escape_character_is_not_a_backslash():
|
|
"""A backslash ESCAPE clause is ambiguous under MySQL/MariaDB string parsing."""
|
|
assert LIKE_ESCAPE != "\\"
|